Re: Proposal for Signal Detection Refactoring - Mailing list pgsql-hackers

From Chris Travers
Subject Re: Proposal for Signal Detection Refactoring
Date
Msg-id CAN-RpxCLmSwSAKyuydMcPv9KczhhJGKuu65YYz2-0xgZTHC3Sw@mail.gmail.com
Whole thread Raw
In response to Re: Proposal for Signal Detection Refactoring  (Chris Travers <chris.travers@adjust.com>)
Responses Re: Proposal for Signal Detection Refactoring  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Latest patch, simpler but answers the key questions as code comments

On Mon, Dec 3, 2018 at 6:56 AM Chris Travers <chris.travers@adjust.com> wrote:
On Thu, Nov 29, 2018 at 8:46 PM Dmitry Dolgov <9erthalion6@gmail.com> wrote:
> On Wed, Oct 10, 2018 at 7:10 PM Chris Travers <chris.travers@adjust.com> wrote:
>
>> More generally, I'd like this material to be code comments.  It's the
>> kind of stuff that gets outdated before long if it's kept separate.
>
> The problem is that code comments are not going to be good places to document "how do I check for pending actions?"  That could be moved to the main SGML I guess.....

I aggree with Peter here, for me it also feels more natural to have this
information as code commentaries - at least if I would search for it that would
be my first thought. As for "how do I..." part, I think there are alreasy
similar commentaries in the code, which makes sense - this kind of questions
usually appear when you're reading/writing some code.

It doesn't look like there is much left to do in this discussion, but for now
I'll move it to the next CF.

Ok will move this into code comments if there are no objections. 


--
Best Regards,
Chris Travers
Head of Database

Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com 
Saarbrücker Straße 37a, 10405 Berlin



--
Best Regards,
Chris Travers
Head of Database

Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com 
Saarbrücker Straße 37a, 10405 Berlin

Attachment

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
Next
From: Amit Langote
Date:
Subject: Re: speeding up planning with partitions