Re: [PATCH] ALTER TABLE ... SET STORAGE default - Mailing list pgsql-hackers

From Nikita Malakhov
Subject Re: [PATCH] ALTER TABLE ... SET STORAGE default
Date
Msg-id CAN-LCVP6qrS-9icHNmv1qfmQRBE-XG3udDHiOTg6n7kTBzTVnA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] ALTER TABLE ... SET STORAGE default  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Hi!

Anyway, adding a paragraph with default storage mode for each standard data type seems 
like a good idea and I'd prepare a patch for it.
Thank you!

On Mon, Aug 22, 2022 at 4:28 PM Aleksander Alekseev <aleksander@timescale.com> wrote:
Hi Nikita,

> This seems a little bit confusing and thus very unfriendly for the user, because the actual meaning
> of the same 'DEFAULT' option will be different for each data type, and to check storage mode user
> has to query full table (or column) description.
> I'd rather add a paragraph in documentation describing each data type default storage mode.

I agree that "SET STORAGE default" syntax leaves much to be desired.

Personally I would prefer "RESET STORAGE" and "RESET COMPRESSION". But
since we already have "SET COMPRESSION default" this going to be
either two commands that do the same thing, or a broken backward
compatibility. Simply removing "SET COMPRESSION default" will make the
syntax consistent too, but again, this would be a broken backward
compatibility. I would argue that a sub-optimal but consistent syntax
that does the job is better than inconsistent syntax and figuring out
the default storage strategy manually.

But let's see what is others people opinion.

--
Best regards,
Aleksander Alekseev


--
Regards,
Nikita Malakhov

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: re: Change pfree to accept NULL argument
Next
From: Robert Haas
Date:
Subject: Re: making relfilenodes 56 bits