> 0002_toaster_interface_v10 contains TOAST API with Dummy toaster as an example (but I would, > as recommended, remove Dummy toaster and provide it as an extension), and default Toaster > was left as-is (reference implementation). > > 0003_toaster_default_v9 implements reference TOAST as Default Toaster via TOAST API, > so Heap AM calls Toast only via API, and does not have direct calls to Toast functionality. > > 0004_toaster_snapshot_v8 continues refactoring and has some important changes (added > into README.toastapi new part related TOAST API extensibility - the virtual functions table).
This numbering is confusing. Please use a command like:
``` git format-patch origin/master -v 42 ```
This will produce a patchset with a consistent naming like:
Unfortunately the three patches in question from this branch don't pass `make check`. Please update src/test/regress/expected/publication.out and make sure the patchset passes the rest of the tests at least on one platform before submitting.
Personally I have a little set of scripts for this [2]. The following commands should pass:
``` # quick check ./quick-build.sh && ./single-install.sh && make installcheck
# full check ./full-build.sh && ./single-install.sh && make installcheck-world ```
Finally, please update the commit messages. Each commit message should include a brief description (one line) , a detailed description (the body), and also the list of the authors, the reviewers and a link to the discussion. Please use [3] as a template.