Hi all,
On Tue, Dec 16, 2025 at 3:20 AM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> On Mon, Dec 8, 2025 at 2:14 AM Soumya S Murali
> <soumyamurali.work@gmail.com> wrote:
> >
> > Here I made some changes in the logic of the function that only returns a real LSN when the buffer actually needs a
WALflush. If the buffer is not permanent or doesn’t need WAL, it returns false and set the LSN to InvalidXLogRecPtr, by
whichit can avoid confusions or unsafe downstream behaviors.
>
> Thanks for the suggestions. It would be best if you attached a patch
> instead of pasting it in the email like this with no formatting (and
> no diff). It is very hard to tell what you've changed.
>
> - Melanie
Thank you for the clarification.
I understand the concern, and apologies for the earlier confusion. My
intention is to stay aligned with the direction of your v11 series, so
this patch contains only small, incremental changes intended to be
easy to review and not conflict with ongoing work.
My previous message was only meant to summarize logic I was
experimenting with locally, not to propose it as a final patch. Based
on the feedback, I revisited the implementation, made the necessary
modifications, and verified the updated logic.
I am attaching the patch for review. It has been tested with make
check and make -C src/test/isolation check.
Thank you again for the guidance. I hope this is helpful for the
ongoing work, and I am looking forward to further feedback.
Regards
Soumya
