Re: 001_password.pl fails with --without-readline - Mailing list pgsql-hackers

From Soumya S Murali
Subject Re: 001_password.pl fails with --without-readline
Date
Msg-id CAMtXxw_kvxZPMnUu5dgTyVwRhwgaFDXAMW4UwhOuUURKHT6U1Q@mail.gmail.com
Whole thread Raw
In response to 001_password.pl fails with --without-readline  (Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>)
List pgsql-hackers
Hi,

I reapplied the patch and tested the patch with (enable-tap-tests +
readline and enable-tap-tests + without-readline). I think the issue
was caused by differences in how psql emits prompts and echoed output
without readline which could lead to banner interleaving, timeouts or
premature TAP termination. In my patch I included the fixes that make
banner detection in BackgroundPsql.pm to be tolerant while keeping
strict line-based cleanup to preserve correct TAP behavior. The fix is
behavior-based and does not rely on configuration variables or test
skipping.
Kindly review my patch attached herewith and please let me know the feedback.

Regards
Soumya

Attachment

pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: CREATE TABLE LIKE INCLUDING TRIGGERS
Next
From: Dharin Shah
Date:
Subject: Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs