2015-05-21 1:49 GMT+09:00 Heikki Linnakangas <hlinnaka@iki.fi>:
On 05/20/2015 07:29 PM, CharSyam wrote:
Hi,
I changed typos error. and attached patch for this. Thanks you.
I only changed comments only
Thanks, committed. Except for this one:
--- src/backend/utils/sort/logtape.c +++ src/backend/utils/sort/logtape.c @@ -926,7 +926,7 @@ LogicalTapeBackspace(LogicalTapeSet *lts, int tapenum, size_t size) /* * Seek to an arbitrary position in a logical tape. * - * *Only* a frozen-for-read tape can be seeked. + * *Only* a frozen-for-read tape can be sought. * * Return value is TRUE if seek successful, FALSE if there isn't that much * data in the tape (in which case there's no state change).
It's true that the past tense of "seek" is "sought", but it feels a bit weird to me in this context. This is a comment on a function called "<blah blah>seek", and it's not clear to me that it should conjugate like the normal "seek" verb.
