Re: pgbench --startup option - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: pgbench --startup option
Date
Msg-id CAMkU=1zVbjsQFARCdVUgGjb+k+Xw1cedTCwB_DhXVqnyKHLbxA@mail.gmail.com
Whole thread Raw
In response to Re: pgbench --startup option  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: pgbench --startup option  (Fabien COELHO <coelho@cri.ensmp.fr>)
Re: pgbench --startup option  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Sun, Jun 16, 2013 at 9:42 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
On Thu, May 2, 2013 at 11:25 AM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:


 
Thanks for doing the review.  I'm not sure what things to go change without further feedback/discussion, except point 4.  I'll wait a day to see if I get more feedback on the other issues and submit a new patch.


I've fixed a conflict, and I've removed extraneous semicolons from the C.

I've left in the fixing of some existing bad indenting in the existing code, which is not strictly related to my change.

I hope my defenses of the other points were persuasive.

Cheers,

Jeff

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: backend hangs at immediate shutdown (Re: Back-branch update releases coming in a couple weeks)
Next
From: Fujii Masao
Date:
Subject: Re: Fix pgstattuple/pgstatindex to use regclass-type as the argument