Re: Check for interrupts in bf and xdes crypt() - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: Check for interrupts in bf and xdes crypt()
Date
Msg-id CAMkU=1yg97x03MQuLFWYcqqajucLZ=gMD9R9XRBFQ8JBNtk5SQ@mail.gmail.com
Whole thread Raw
In response to Check for interrupts in bf and xdes crypt()  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Check for interrupts in bf and xdes crypt()  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Tue, Dec 15, 2015 at 12:35 AM, Andreas Karlsson <andreas@proxel.se> wrote:
> Hi,
>
> Here is a patch which makes it possible to cancel a query which runs the
> crypt() function with the bf or xdes hashing algorithm, e.g. crypt('foo',
> gen_salt('bf', 13)). The md5 algorithm does not run for multiple rounds so
> there is no reason to patch it.
>
> I noticed this problem when I accidentally picked a too high n for the
> number of hash rounds.
>
> I have added a call to CHECK_FOR_INTERRUPTS() after every round, and I could
> not measure any performance hit from this.

Looks good to me.  Applies, builds, passes make check, does what it
says and says what it does.  No need for docs, no noticeable
performance impact.

I've marked it ready for committer.  Also recommend for back-patching.

Cheers,

Jeff



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Add numeric_trim(numeric)
Next
From: Jeff Janes
Date:
Subject: Avoid endless futile table locks in vacuuming.