Postgres Pro
Downloads
Home   >   mailing lists

WAL format changes break the suppression of do-nothing checkpoints. - Mailing list pgsql-hackers

From Jeff Janes
Subject WAL format changes break the suppression of do-nothing checkpoints.
Date
Msg-id CAMkU=1yTyPkuM=JvKszDjHsxYmnwCoLBxJVqmY3KXujym-0OLw@mail.gmail.com
Whole thread Raw
Responses Re: WAL format changes break the suppression of do-nothing checkpoints.
List pgsql-hackers
Tree view
commit 2c03216d831160bedd72d45f7 has invalidated the part of the docs saying "If no WAL has been written since the previous checkpoint, new checkpoints will be skipped even if checkpoint_timeout has passed", presumably by accident.

It seems that this part is no longer true when it should be true:

        if (curInsert == ControlFile->checkPoint +
            MAXALIGN(SizeOfXLogRecord + sizeof(CheckPoint))

MAXALIGN(SizeOfXLogRecord + sizeof(CheckPoint) is now 96, but the amount by which curInsert gets advanced is still 104, like it was before the commit.


Cheers,

Jeff


pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0
Next
From: "Joshua D. Drake"
Date:
Subject: Bug #10432 failed to re-find parent key in index