Postgres Pro
Downloads
Home   >   mailing lists

Re: ALTER TABLE ... ALTER CONSTRAINT - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: ALTER TABLE ... ALTER CONSTRAINT
Date
Msg-id CAMkU=1xjGqkeC4gmp_bz0YBoXznkzBvV0WUA18ZqqXRzM14big@mail.gmail.com
Whole thread Raw
In response to Re: ALTER TABLE ... ALTER CONSTRAINT  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Responses Re: ALTER TABLE ... ALTER CONSTRAINT  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
Tree view
On Sun, Jun 23, 2013 at 8:58 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
At 2013-06-08 21:45:24 +0100, simon@2ndQuadrant.com wrote:
>
> ALTER TABLE foo
>    ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE;

I read the patch (looks good), applied it on HEAD (fine), ran make check
(fine), and played with it in a test database. It looks great, and from
previous responses it's something a lot of people have wished for.

I'm marking this ready for committer.

After the commit, I'm now getting the compiler warning:

tablecmds.c: In function 'ATPrepCmd':
tablecmds.c:2953: warning: 'pass' may be used uninitialized in this function


case AT_AlterConstraint (line 3130) is the only case branch that does not set pass.

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
Next
From: Tom Lane
Date:
Subject: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]