Re: Issue with query_is_distinct_for() and grouping sets - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Issue with query_is_distinct_for() and grouping sets
Date
Msg-id CAMbWs49bc4JWn_f9AWFaouZUdurQCPeEmBwMEE-aJymY3UkFRg@mail.gmail.com
Whole thread Raw
In response to Issue with query_is_distinct_for() and grouping sets  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Issue with query_is_distinct_for() and grouping sets
List pgsql-hackers
On Wed, Oct 22, 2025 at 6:25 PM Richard Guo <guofenglinux@gmail.com> wrote:
> Attached is a patch along the lines of option #2.  The LCOV report
> indicates that there is currently no test coverage for the "else if
> (query->groupingSets)" branch in query_is_distinct_for().  This patch
> also adds test cases to cover that branch.

Here is an updated patch that includes a commit message and adds a new
test case involving DISTINCT clause used with GROUP BY.

- Richard

Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Next
From: David Rowley
Date:
Subject: Re: Issue with query_is_distinct_for() and grouping sets