Re: remove_useless_joins vs. bug #19560 - Mailing list pgsql-hackers

From Richard Guo
Subject Re: remove_useless_joins vs. bug #19560
Date
Msg-id CAMbWs49LS9AMn-MV2Zm7xZ6kjZJMa4gVuH_h83nF=7U+0m322Q@mail.gmail.com
Whole thread
In response to Re: remove_useless_joins vs. bug #19560  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: remove_useless_joins vs. bug #19560
Re: remove_useless_joins vs. bug #19560
List pgsql-hackers
On Thu, Sep 17, 2026 at 11:52 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> The main consumer of varnosyn is ruleutils.c, so I don't like
> the fact that this test case isn't showing what ruleutils will
> do with the Var.  If we make it be "explain verbose", do we
> get a display of the problematic Var?

The Var is displayed, but not via varnosyn.  ruleutils.c uses varnosyn
only when dpns->plan is NULL, and EXPLAIN always sets the plan before
deparsing an expression, so it prints the semantic referent (a.b_id).

But I think it'd still be better to use "explain verbose", so at least
what ruleutils prints is recorded.  I'll make that change before push.

- Richard



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized pgstats hash entry
Next
From: Denis Smirnov
Date:
Subject: Re: [PATCH] libpq: Add PQpassfileLookup()