Re: Clean up remove_rel_from_query() after self-join elimination commit - Mailing list pgsql-hackers

On Mon, Apr 20, 2026 at 9:49 AM wenhui qiu <qiuwenhuifx@gmail.com> wrote:
> > Assert(!is_outer_join || joinrelids != NULL);
>
> > Worth asserting.  If a caller sets sjinfo but passes NULL for
> > joinrelids, this would silently over-delete PHVs.
> > Assert(!is_self_join || joinrelids == NULL);
>
> LGTM with the added assertion.

Thanks.  Committed.

- Richard