Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c - Mailing list pgsql-bugs

From Richard Guo
Subject Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c
Date
Msg-id CAMbWs48z_7Vc8_Q93QEuUaB6n3-rJPO0f8KF=gbogzTmK4hvpA@mail.gmail.com
Whole thread Raw
In response to Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c  (RekGRpth <rekgrpth@gmail.com>)
Responses Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c
Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c
List pgsql-bugs
Tree view

On Thu, Dec 7, 2023 at 12:41 AM RekGRpth <rekgrpth@gmail.com> wrote:
Fixed!

Nice catch.

There are several places in DecodeDateTime() where the value of '*tzp'
is changed.  It seems to me that these assignments are unnecessary since
the value of '*tzp' is not utilized anywhere in the code.  Can we also
remove these assignments?

Thanks
Richard

pgsql-bugs by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c
Next
From: RekGRpth
Date:
Subject: Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c