Re: Improve list manipulation in several places - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Improve list manipulation in several places
Date
Msg-id CAMbWs4-vs=SGXYYs89Kkqdcn78emKGdbzqF_p3v4WX5C9VnYGw@mail.gmail.com
Whole thread Raw
In response to Re: Improve list manipulation in several places  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers

On Mon, May 8, 2023 at 11:22 PM Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
On 23.04.23 08:42, Richard Guo wrote:
> Thanks for the suggestion.  I've split the patch into two as attached.
> 0001 is just a minor simplification by replacing lfirst(list_head(list))
> with linitial(list).  0002 introduces new functions to reduce the
> movement of list elements in several places so as to gain performance
> improvement and benefit future callers.

These look sensible to me.  If you could show some numbers that support
the claim that there is a performance advantage, it would be even more
convincing.

Thanks Peter for looking at those patches.  I tried to devise a query to
show performance gain but did not succeed :-(.  So I begin to wonder if
0002 is worthwhile to do, as it seems that it does not solve any real
problem.

Thanks
Richard

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cleaning up array_in()
Next
From: Peter Smith
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node