Re: Potential partition pruning regression on PostgreSQL 18 - Mailing list pgsql-hackers

On Tue, Apr 7, 2026 at 5:00 PM Richard Guo <guofenglinux@gmail.com> wrote:
> Here are the more formal patches for HEAD and for v18.
>
> In the HEAD patch, I renamed strip_phvs_in_index_operand() to
> strip_noop_phvs() and moved it from indxpath.c to placeholder.c, since
> it is now a general-purpose utility used by both index matching and
> partition pruning code.
>
> However, since strip_phvs_in_index_operand() is an extern function
> declared in a public header, I'm worried that third-party extensions
> may have started calling it after it was introduced in ad66f705f.  So
> for the v18 back-patch, I retained strip_phvs_in_index_operand() in
> indxpath.c as a thin wrapper around the new strip_noop_phvs(), to
> avoid breaking such extensions in a minor release.
>
> Does this seem like reasonable caution, or is it overkill given how
> recently the function was introduced?

I prefer to be cautious, so I've committed the patches as-is.

- Richard