Re: BUG: deadlock between autovacuum worker and client backend during removal of orphan temp tables with sequences - Mailing list pgsql-hackers

From Akshat Jaimini
Subject Re: BUG: deadlock between autovacuum worker and client backend during removal of orphan temp tables with sequences
Date
Msg-id CAMaW3Vic0XmEvLz=Rv-_ODQfxOz3OsitjxahGxH5Nif32P0REA@mail.gmail.com
Whole thread Raw
In response to Re: BUG: deadlock between autovacuum worker and client backend during removal of orphan temp tables with sequences  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi apologies for the late reply.
> Maybe you forgot to recompile/reinstall after updating past that commit?
I did recompile it earlier but just to be sure I followed the steps again and now its working!

Regards,
Akshat Jaimini

On Wed, Apr 3, 2024 at 12:34 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Akshat Jaimini <destrex271@gmail.com> writes:
> The code seems to implement the feature and has good and explanatory comments associated with it.
> I believe we can go ahead with committing patch although I would request some senior contributors to also take a look at this patch since I am relatively new to patch reviews.

Looks like a good catch and a reasonable fix.  Pushed after rewriting
the comments a bit.

As far as this goes:

> I ran make installcheck-world after applying the patch and recompiling it. It did fail for a particular test but from the logs it seems to be unrelated to this particular patch since it fails for the following:

> ==========================
> select error_trap_test();
> -      error_trap_test     
> ----------------------------
> - division_by_zero detected
> -(1 row)
> -
> +ERROR:  cannot start subtransactions during a parallel operation

... that's the test case from 0075d7894, and the failure is what
I'd expect from a backend older than that.  Maybe you forgot to
recompile/reinstall after updating past that commit?

                        regards, tom lane

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Streaming read-ready sequential scan code
Next
From: Michael Paquier
Date:
Subject: Re: Autogenerate some wait events code and documentation