Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup - Mailing list pgadmin-hackers

From Jan Alexander Steffens
Subject Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup
Date
Msg-id CAMQ-g0dxWFV_xOByCgVdyRSG2vywMjJ98H93=Rtxf+9bHOnDJA@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
On Fri, Jan 27, 2017 at 5:56 PM Dave Page <dpage@pgadmin.org> wrote:
On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens
<jan.steffens@gmail.com> wrote:
> I did mean Py_SetPath, not PySys_SetPath.

Ah, OK - it wouldn't compile with that (Python 2 :-/ ) so I assumed it
was a typo.

> Unfortunately, after checking
> again it turns out this is Python 3 only. Python 2 has no means of changing
> the module_search_path from outside. So, there it definitely needs a
> restart. :-(

Yeah :-(. How does the attached patch look to you?

Looks good to me, thanks! I've tested both selecting a venv and the venv-beside-runtime.

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2015 - Trigger issues
Next
From: Surinder Kumar
Date:
Subject: [pgadmin-hackers] [pgAdmin4][Patch]: RM2047 - Allow user to move panel over the menu bar