Re: Fixing tab-complete for dollar-names - Mailing list pgsql-hackers

From Mikhail Gribkov
Subject Re: Fixing tab-complete for dollar-names
Date
Msg-id CAMEv5_t2-8nUOk7t1xYUNU6G=0O0sfXaBwJM1A=1vetaaz53=g@mail.gmail.com
Whole thread Raw
In response to Fixing tab-complete for dollar-names  (Mikhail Gribkov <youzhick@gmail.com>)
Responses Re: Fixing tab-complete for dollar-names
List pgsql-hackers
Hi hackers,

As not much preliminary interest seem to be here, I'm sending the patch to the upcoming commitfest

--
 best regards,
    Mikhail A. Gribkov


On Sat, Jun 17, 2023 at 12:51 AM Mikhail Gribkov <youzhick@gmail.com> wrote:
Hi hackers,

In modern versions of Postgres the dollar sign is a totally legal character for identifiers (except for the first character), but tab-complete do not treat such identifiers well.
For example if one try to create an Oracle-style view like this:

create view v$activity as select * from pg_stat_activity;

, he will get a normally functioning view, but psql tab-complete will not help him. Type "v", "v$" or "v$act" and press <TAB> - nothing will be suggested.

Attached is a small patch fixing this problem.
Honestly I'm a little surprised that this was not done before. Maybe, there are some special considerations I am not aware of, and the patch will break something?
What would you say?
--
 best regards,
    Mikhail A. Gribkov

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Analyze on table creation?
Next
From: Andres Freund
Date:
Subject: Re: Stampede of the JIT compilers