Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] Shadowing variables - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][SonarQube] Shadowing variables
Date
Msg-id CAM9w-_my=+QBRPTY2fQ58_9CP4NmN6r931hBTjVNAPNbKeGaaA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][SonarQube] Shadowing variables  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][SonarQube] Shadowing variables  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Hackers,

Attached is the patch to fix a few more SonarQube reported issues(around 28) related to "potential hiding of variables declared in an outer scope".
Please review.

On Tue, Jul 14, 2020 at 4:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Mon, Jul 13, 2020 at 10:15 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the SonarQube reported issues (40+) which potentially hides a variable declared in an outer scope.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Regards,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Added docstrings for some newly created functions.
Next
From: Dave Page
Date:
Subject: Runtime refactoring