Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for SonarQube code scan fixes. - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: Patch for SonarQube code scan fixes.
Date
Msg-id CAM9w-_mgC6O1Pb36F_BiG8mt5_5BRAT1XCO0etkLCO+Ux78o8A@mail.gmail.com
Whole thread Raw
In response to Patch for SonarQube code scan fixes.  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Responses Re: Patch for SonarQube code scan fixes.
List pgadmin-hackers
Tree view
Hi,

sqlautocomplete code is mostly inherited from the pgcli project. Changing it might create trouble in updating the code with new versions.

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. psycopg2/connection:
  • Refactor this function to reduce its Cognitive Complexity from 32 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
2. psycopg2/server_manager:
  • Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed.
3. sqlautocomplete/parseutils:
  • Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.


--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Nikhil Mohite
Date:
Subject: Patch for SonarQube code scan fixes.
Next
From: Dave Page
Date:
Subject: Re: Patch for SonarQube code scan fixes.