Re: [pgAdmin][RM7351]: Templates not displayed - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][RM7351]: Templates not displayed
Date
Msg-id CAM9w-_meoBawdmJFA5f0PKB0jDvErMrXnBfx7MBtpr_K4oxEoA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM7351]: Templates not displayed  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin][RM7351]: Templates not displayed  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Dave,

On Wed, May 11, 2022 at 2:00 PM Dave Page <dpage@pgadmin.org> wrote:


On Wed, 11 May 2022 at 09:24, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

On Wed, May 11, 2022 at 1:24 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

I think this change needs some thought and discussion on how it should be implemented. pgAdmin has worked this way for over 20 years with only this one suggestion to change afaicr - and I for one don't suddenly want templates showing up amongst my other databases.
User defined template DBs cannot come under "Show system objects". I mean, they're not system objects.

No they're not. But we have over 20 years of them being classed that way, and users may not suddenly want to see template1 (for example) listed amongst their databases. There are various things to think about here, for example:
No template1, template0 are system objects. They won't be visible. Only new databases created manually and marked as template are excluded from "Show system objects" .

- Should there be a separate option to show/hide template databases?
- If so, what should the default be (hint: I think yes, and off)
- Should template databases have a different icon?
We can have this. Good to differentiate. 
- Should they have their own collection node?
- They can't be connected to, so much of what's on the database properties dialog won't work. Should they have their own properties dialogue design?
I can connect to template DBs in pgAdmin.

 

On Wed, 11 May 2022 at 07:12, Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for # 7351:Templates not displayed.

I have fixed below issues
  1. Databases which are marked as template manually by the user should be visible independent of - "Show System Objects".
  2.  DB properties dialogs should allow you to change template flag in edit mode.


--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin][RM7351]: Templates not displayed
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin][RM7351]: Templates not displayed