Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes
Date
Msg-id CAM9w-_mcbpeO8vWcVGeXqP=XXTOigrD+DT9vkfne7_FZARUBbg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi,

The jasmine test cases are failing with this commit. Attached is the patch to fix the test cases.

On Fri, Jul 3, 2020 at 11:49 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Jul 2, 2020 at 5:54 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Change the way editable field is displayed in backgrid.
2) Change colors for alerts in dark theme.
3) Change the dashboard graph grid lines colors based on theme.
4) Fix the backgrid hover background issue. Fixes #5470.
5) Few other CSS improvements.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: Patch for SonarQube code scan fixes
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed jasmin test cases failed due to last commit.