Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] Reduce cognitive complexity - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Date
Msg-id CAM9w-_mJ=4pOPrXcv+1_e8G=bd7UCZ9OoV=p0PposQcLfF76eQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][SonarQube] Reduce cognitive complexity  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi,

Please find the updated patch.

On Tue, Sep 22, 2020 at 2:56 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

The patch fixes only 1 code smell and introduce 1 new. Please fix those and resend the patch.

On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached path will reduce the cognitive complexity as below:web/pgadmin/misc/file_manager/__init__.py 40 to 15; 43 to 15

Please review.


--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Improve code coverage and API test cases for Function