Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved
Date
Msg-id CAM9w-_mByKngJX_tX2ED8JHgaEFXRpMuyZMTX5d=ww4DKZ2qow@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin][RM4564] JS errors in the Query Tool are caught as ajax errors
Next
From: Aditya Toshniwal
Date:
Subject: [pgAdmin][RM4610] Enter key on search box for dropdown intercepted by modal