Hi AdityaI have tested it. Reset functionality not working when preference setting is set to False. Please fix and resend the patch.On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,As discussed, extending the changes to Reset button also. Warning will appear for Reset button now if opted in preferences and changes are not saved.Note that, the preference option is same for Close and Reset button.Kindly review.On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:On Wed, Oct 30, 2019 at 3:44 PM Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:HiI just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-oTested all but missed the obvious. Bad miss :/Attached is the patch to fix the issue. Thanks - applied. Should we also warn on Reset? That seems logical to me.Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. Can you fix that ASAP please?On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:Thanks, applied.On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Hi Hackers,As discussed, extending the changes to Reset button also. Warning will appear for Reset button now if opted in preferences and changes are not saved.Note that, the preference option is same for Close and Reset button.Kindly review.On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:On Wed, Oct 30, 2019 at 3:44 PM Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:HiI just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-oTested all but missed the obvious. Bad miss :/Attached is the patch to fix the issue. Thanks - applied. Should we also warn on Reset? That seems logical to me.Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. Can you fix that ASAP please?On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:Thanks, applied.On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
On Wed, Oct 30, 2019 at 3:44 PM Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:HiI just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-oTested all but missed the obvious. Bad miss :/Attached is the patch to fix the issue. Thanks - applied. Should we also warn on Reset? That seems logical to me.Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. Can you fix that ASAP please?On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:Thanks, applied.On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
HiOn Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:HiI just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-oTested all but missed the obvious. Bad miss :/Attached is the patch to fix the issue. Thanks - applied. Should we also warn on Reset? That seems logical to me.
Hi,On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:HiI just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-oTested all but missed the obvious. Bad miss :/Attached is the patch to fix the issue.
HiI just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Can you fix that ASAP please?On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:Thanks, applied.On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
Can you fix that ASAP please?On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:Thanks, applied.On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Can you fix that ASAP please?On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:Thanks, applied.On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
Thanks, applied.On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
Hi Hackers,Attached is the patch to warn the user before closing an unsaved properties dialog.Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.Docs updated.Kindly review.-- Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных
