Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] Reduce cognitive complexity - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Date
Msg-id CAM9w-_kw65GyBa2XxvkOYa6Kovx10BqixXGN8bD8B1CimFKZDg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][SonarQube] Reduce cognitive complexity  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][SonarQube] Reduce cognitive complexity  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Hackers,

Attached is the patch to fix certain errors occurring when saving preferences. This is the regression of patch committed.
Please review.

On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch will reduce cognitive complexity for functions as below:
web/.../servers/pgagent/schedules/__init__.py - 17 to 15
web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
web/pgadmin/setup/user_info.py - 22 to 15
web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed an issue where debugger doesn't work if the sea
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed errors occurring when saving preferences, regre