Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Date
Msg-id CAM9w-_=tKBBMaJmKSaRnhrdCWjk-D+SWd=BxwxYuHJwCv8nrmw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
List pgadmin-hackers
Hi Hackers,

Attached is the patch to customize the scrollbar styling. A new SASS variable added - $scrollbar-base-color is added to change the color as per theme.
Please note, customization of scrollbar works only in webkit browsers like Chrome, Safari. Mozilla does not have any way to customize.

Kindly review.

On Tue, Nov 12, 2019 at 5:55 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Tue, Nov 12, 2019 at 3:41 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:


On Tue, Nov 12, 2019 at 3:25 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Nov 12, 2019 at 9:50 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Attached. It may just be that it looks a little sharp because it's a long line. Maybe we should just make it a darker shade entirely.

Screenshot 2019-11-12 at 09.09.42.png

Why can't I see it :/
Maybe it got fixed along with the dark drop down for no limit. Could you please check again.
image.png

Nope, it's definitely still there:
I checked on 2-3 systems. It looks fine. May be the permanent enabled scrollbar causing it look like that.

Screenshot 2019-11-12 at 09.53.02.png

 
BTW, what was the reason for removing the styling from the scroll bars?
We had given gray shades to scrollbar which were not clearly visible for some tables. Plus, for systems were scrollbar is not always enabled was showing scrollbar. It should appear only on scroll on those systems.

And you're working on that? We can't keep the ugly grey scroll bars!
OK. I'll take it as priority. 

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Shubham Agarwal
Date:
Subject: Re: Fixes for pgAdmin feature tests
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme