Hi Surinder,[Please do not forget to "Reply All" (and, not reply to me personally)..]
On Wed, Feb 3, 2016 at 4:37 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:Hi,Please find the patch with suggested changes.I've updated the patch with some minor changes.Please test me, and let me know (if it is working in your environment with the view node, which you're working on.)
Hi,Please find the patch with suggested changes.
--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashiThanksSurinder KumarOn Wed, Feb 3, 2016 at 10:49 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Surinder,On Tue, Feb 2, 2016 at 1:05 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:Hi,Please find patch for SqlFieldControl.Thanks for the patch. This control allows the user to write/edit SQL queries.K To use SqlFieldControl, Set control property of field to 'sql-field' in model's schema like:{ id: 'definition', label:'{{ _('Definition') }}', cell: 'string', control: 'sql-field'}K.Please extend the SqlFieldContorl from the Backform.TextareaControl instead of Backform.Control.Done * Do not need to set events, TextareaControl has handled those events.Done * Extend 'getValueFromDom' function in order to get the value from the sql, and set it to the model.Done * Don't listen to the 'pg-property-tab-changed' event here. (It is redundant here). In your implementation, you're already refreshing lazely using setTimeout function, which should refresh issue of CodeMirror any way. There is an issue with Code mirror control, so after discussion its added. As per our personal discussion, please update the 'updateInvalid' function for the Control to look for only the 'input' tag with 'name' attribute. As per discussion, this change is required for all 'input' tag, so removed it from SqlFieldControl and changed it in updateInvalid function--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashi Regards,Surinder Kumar -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers
--
Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Company
http://www.linkedin.com/in/asheshvashi
ThanksSurinder KumarOn Wed, Feb 3, 2016 at 10:49 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Surinder,On Tue, Feb 2, 2016 at 1:05 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:Hi,Please find patch for SqlFieldControl.Thanks for the patch. This control allows the user to write/edit SQL queries.K To use SqlFieldControl, Set control property of field to 'sql-field' in model's schema like:{ id: 'definition', label:'{{ _('Definition') }}', cell: 'string', control: 'sql-field'}K.Please extend the SqlFieldContorl from the Backform.TextareaControl instead of Backform.Control.Done * Do not need to set events, TextareaControl has handled those events.Done * Extend 'getValueFromDom' function in order to get the value from the sql, and set it to the model.Done * Don't listen to the 'pg-property-tab-changed' event here. (It is redundant here). In your implementation, you're already refreshing lazely using setTimeout function, which should refresh issue of CodeMirror any way. There is an issue with Code mirror control, so after discussion its added. As per our personal discussion, please update the 'updateInvalid' function for the Control to look for only the 'input' tag with 'name' attribute. As per discussion, this change is required for all 'input' tag, so removed it from SqlFieldControl and changed it in updateInvalid function--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashi Regards,Surinder Kumar -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers
Hi Surinder,On Tue, Feb 2, 2016 at 1:05 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:Hi,Please find patch for SqlFieldControl.Thanks for the patch. This control allows the user to write/edit SQL queries.K To use SqlFieldControl, Set control property of field to 'sql-field' in model's schema like:{ id: 'definition', label:'{{ _('Definition') }}', cell: 'string', control: 'sql-field'}K.Please extend the SqlFieldContorl from the Backform.TextareaControl instead of Backform.Control.
Hi,Please find patch for SqlFieldControl.
This control allows the user to write/edit SQL queries.
To use SqlFieldControl, Set control property of field to 'sql-field' in model's schema like:{ id: 'definition', label:'{{ _('Definition') }}', cell: 'string', control: 'sql-field'}
* Do not need to set events, TextareaControl has handled those events.
* Extend 'getValueFromDom' function in order to get the value from the sql, and set it to the model.
* Don't listen to the 'pg-property-tab-changed' event here. (It is redundant here).
In your implementation, you're already refreshing lazely using setTimeout function, which should refresh issue of CodeMirror any way.
As per our personal discussion, please update the 'updateInvalid' function for the Control to look for only the 'input' tag with 'name' attribute.
--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashi Regards,Surinder Kumar -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers
Regards,Surinder Kumar -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных