Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager] - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager]
Date
Msg-id CAM5-9D81MtwXQWCfx+EY7Qj5NPuSOb4g9XP8zOsy7MjsWA20Jg@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager]
List pgadmin-hackers
Tree view
Hi,

Issue:
When clicked on upload icon while saving a file prompt user to leave page. It is because the icon is a button and its type is set to submit which makes it to prompt, instead it should be 'button'

Storage Manager's menu items depends on capabilities list set by the module using it. If capabilities doesn't have 'upload' in it, It won't work. Upload button is bound to click event only when it is in capabilities.

Solution:
As upload button is being added only when it is in capabilities, so upload button html is removed from html file. It will not shown on UI untill it is in capabilities list.

Please find attached patch and review.


Thanks,
Surinder Kumar

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Running pgadmin4 as desktop application
Next
From: Surinder Kumar
Date:
Subject: [pgAdmin4][Patch]: Listing of files/folders not sorted alphabetically in Storage Manager