Re: Last Commitfest patches waiting review - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Last Commitfest patches waiting review
Date
Msg-id CAM3SWZSdNysZH98KujQAF6BFL4LwHi82evKj1MacjVWJOpgsFg@mail.gmail.com
Whole thread Raw
In response to Re: Last Commitfest patches waiting review  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: Last Commitfest patches waiting review
List pgsql-hackers
On Thu, Oct 9, 2014 at 12:14 PM, Heikki Linnakangas
<hlinnakangas@vmware.com> wrote:
> B-tree index build uses tuplesort.c. What's missing?

I don't think that all that much is missing. Tuplesort expects to work
with an index scankey when sorting B-Tree tuples. There needs to be
something like a reverse lookup of the sortsupport function. It looks
like a historical oversight, that would take time to fix, but wouldn't
be particularly challenging. You'd need to pick out the operators from
the scankey, so you'd have something like what tuplesort_begin_heap()
starts off with with tuplesort_begin_index_btree().

copytup_index() would then later need to be modifed to make
abbreviation occur there too, but that's no big deal.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pgbench throttling latency limit
Next
From: Andres Freund
Date:
Subject: Re: Scaling shared buffer eviction