Re: Doing better at HINTing an appropriate column within errorMissingColumn() - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Date
Msg-id CAM3SWZS4sg7PQN3Wsoxer3Kx4N0cN16h9bn9nmpqGDY2_d4dtg@mail.gmail.com
Whole thread Raw
In response to Re: Doing better at HINTing an appropriate column within errorMissingColumn()  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Nov 13, 2014 at 8:57 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> My point is: I am not sure I can be defined as a reviewer of this
>> patch or take any credit in this patch review knowing that the latest
>> version submitted is a simple rebase of the version I did my first
>> review on. Hence, code speaking, this patch is in the same state as
>> when it has been firstly submitted.
>
> Of course you can.  Time spent reviewing is time spent reviewing,
> whether it results in changes to the patch or not.


My thoughts exactly. I thought Michael did a good job, even if I
didn't agree with everything he said.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Next
From: Robert Haas
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()