Re: checksum_impl.h fails cpluspluscheck - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: checksum_impl.h fails cpluspluscheck
Date
Msg-id CAM3SWZRa8J1zk1C6hghiXXKTy+r1KevPDBzTR1245uC_O7bvbg@mail.gmail.com
Whole thread Raw
In response to checksum_impl.h fails cpluspluscheck  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Sat, Jun 29, 2013 at 8:55 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> ./src/include/storage/checksum_impl.h: In function ‘uint32 pg_checksum_block(char*, uint32)’:
> ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions

On the subject of checksum_impl.h, don't you think it's a bit
unfortunate that clients have to do this?:

+ // checksum_impl.h uses Assert, which doesn't work outside the server
+ #undef Assert
+ #define Assert(X)
+
+ #include "storage/checksum_impl.h"
+

Maybe external utilities ought to include another header that does all
of this for them?

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: checksum_impl.h fails cpluspluscheck
Next
From: Michael Paquier
Date:
Subject: Re: pg_ctl and -h/help