Re: fd.c doesn't remove files on a crash-restart - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: fd.c doesn't remove files on a crash-restart
Date
Msg-id CAM3SWZREPVKc80Dog+R2sxW=wt+LfCjTyCBPStWo4yA3+zigiA@mail.gmail.com
Whole thread Raw
In response to fd.c doesn't remove files on a crash-restart  ("Joshua D. Drake" <jd@commandprompt.com>)
List pgsql-hackers
On Wed, Mar 16, 2016 at 10:53 AM, Joshua D. Drake <jd@commandprompt.com> wrote:
> fd.c[1] will remove files from pgsql_tmp on a restart but not a
> crash-restart per this comment:
>
> /*
> * NOTE: we could, but don't, call this during a post-backend-crash restart
> * cycle.  The argument for not doing it is that someone might want to
> examine
> * the temp files for debugging purposes.  This does however mean that
> * OpenTemporaryFile had better allow for collision with an existing temp
> * file name.
> */
>
> I understand that this is designed this way. I think it is a bad idea

FWIW, I've seen this get out of hand several times myself.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: fd.c doesn't remove files on a crash-restart
Next
From: Andres Freund
Date:
Subject: Re: Performance degradation in commit ac1d794