Re: Schizophrenic coding in gin_extract_jsonb(_hash) - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Schizophrenic coding in gin_extract_jsonb(_hash)
Date
Msg-id CAM3SWZQSn33Rin5ziNYLNhnTz+4nhsm9hq_970rSavJQLkpJ5w@mail.gmail.com
Whole thread Raw
In response to Schizophrenic coding in gin_extract_jsonb(_hash)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Schizophrenic coding in gin_extract_jsonb(_hash)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, May 6, 2014 at 8:08 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> The early-exit code path supposes that JB_ROOT_COUNT is absolutely
> reliable as an indicator that there's nothing in the jsonb value.
> On the other hand, the realloc logic inside the iteration loop implies
> that JB_ROOT_COUNT is just an untrustworthy estimate.  Which theory is
> correct?  And why is there not a comment to be seen anywhere?  If the code
> is correct then this logic is certainly worthy of a comment or three.

JsonbIteratorNext() is passed "false" as its skipNested argument. It's
recursive.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: need xmllint on borka
Next
From: Craig Ringer
Date:
Subject: Re: New pg_lsn type doesn't have hash/btree opclasses