<div dir="ltr">Hi Stephen,<br /><div class="gmail_extra"><br /><div class="gmail_quote"><span class="gmail-"></span><br
/><spanclass="gmail-"></span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex"><spanclass="gmail-"> > 4. It will be good if we have an example for this in
section<br/> > "5.7. Row Security Policies"<br /><br /></span>I haven't added one yet, but will plan to do so.<br
/><spanclass="gmail-"><br /></span></blockquote>I think you are going to add this in this patch itself, right?<br /><br
/>Ihave reviewed your latest patch and it fixes almost all my review comments.<br />Also I am agree with your responses
forcouple of comments like response on<br />ALTER POLICY and tab completion. No issues with that.<br /><br />However in
documentation,PERMISSIVE and RESTRICTIVE are actually literals<br />and not parameters as such. Also can we combine
thesetwo options into one<br />like below (similar to how we document CASCADE and RESTRICT for DROP POLICY):<br /><span
style="font-family:monospace,monospace"><br/> <varlistentry><br />
<term><literal>PERMISSIVE</literal></term><br/>
<term><literal>RESTRICTIVE</literal></term><br/><br /> <listitem><br />
<para><br/> ... explain PERMISSIVE ...<br /> </para><br /> <para><br /> ...
explainRESTRICTIVE ...<br /> </para><br /> </listitem><br /> </varlistentry></span><br /><br
/>Apartfrom this changes look excellent to me.<br /><br />Thanks<br /> <br /></div>-- <br /><div
class="gmail_signature"><divdir="ltr">Jeevan B Chalke<br />Principal Software Engineer, Product Development<br
/>EnterpriseDBCorporation<br />The Enterprise PostgreSQL Company<br /><br /></div></div></div></div>
