Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex) - Mailing list pgsql-hackers

From Greg Stark
Subject Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)
Date
Msg-id CAM-w4HPNB=BWJsQiKGWJ0Jxn_hM3QHfZwOvq+tEkB2oLo4K77A@mail.gmail.com
Whole thread
In response to --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)
List pgsql-hackers

Alternately the buildfarm could be changed to retain earlier builds and use dependencies to reduce build times. This would have the benefit of detecting dependency failures. At the expense of a lot more noise, at least until we Orrin out whatever dependency failures are there now.

Or we could add extra rules so that if you don't configure with dependencies we check for unclean builds and error out. This would make at least accidental unclean builds much led likely.

On 30 Dec 2015 16:49, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
[ A change as significant as this should not be debated in a thread with
a title that suggests it's of interest to only one or two people ]

> On Wed, Dec 30, 2015 at 5:44 PM, Andres Freund <andres@anarazel.de> wrote:
>> I still maintain that --enable-depend should be on by default. We're
>> absurdly optimizing towards saving a handful of cycles in scenarios
>> which are usually bottlenecked by other things (build boxes spend more
>> times on tests and such)

Nonsense.  The buildfarm will simply get slower, and at least for my
animals it's too damn slow already.  We could fix that by having the
buildfarm script automatically add --disable-depend; but if we're going
to change this, we should roll out that script update BEFORE we change
it, not after.

                        regards, tom lane


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: rows estimate in explain analyze for the BRIN index
Next
From: Tom Lane
Date:
Subject: Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)