Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex) - Mailing list pgsql-hackers

From Greg Stark
Subject Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)
Date
Msg-id CAM-w4HPNB=BWJsQiKGWJ0Jxn_hM3QHfZwOvq+tEkB2oLo4K77A@mail.gmail.com
Whole thread Raw
In response to --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
<p dir="ltr">Alternately the buildfarm could be changed to retain earlier builds and use dependencies to reduce build
times.This would have the benefit of detecting dependency failures. At the expense of a lot more noise, at least until
weOrrin out whatever dependency failures are there now.<p dir="ltr">Or we could add extra rules so that if you don't
configurewith dependencies we check for unclean builds and error out. This would make at least accidental unclean
buildsmuch led likely.<div class="gmail_quote">On 30 Dec 2015 16:49, "Tom Lane" <<a
href="mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>>wrote:<br type="attribution" /><blockquote class="gmail_quote"
style="margin:00 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">[ A change as significant as this should not be
debatedin a thread with<br /> a title that suggests it's of interest to only one or two people ]<br /><br /> > On
Wed,Dec 30, 2015 at 5:44 PM, Andres Freund <<a href="mailto:andres@anarazel.de">andres@anarazel.de</a>> wrote:<br
/>>> I still maintain that --enable-depend should be on by default. We're<br /> >> absurdly optimizing
towardssaving a handful of cycles in scenarios<br /> >> which are usually bottlenecked by other things (build
boxesspend more<br /> >> times on tests and such)<br /><br /> Nonsense.  The buildfarm will simply get slower,
andat least for my<br /> animals it's too damn slow already.  We could fix that by having the<br /> buildfarm script
automaticallyadd --disable-depend; but if we're going<br /> to change this, we should roll out that script update
BEFOREwe change<br /> it, not after.<br /><br />                         regards, tom lane<br /><br /><br /> --<br />
Sentvia pgsql-hackers mailing list (<a href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br
/>To make changes to your subscription:<br /><a href="http://www.postgresql.org/mailpref/pgsql-hackers"
rel="noreferrer"target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br /></blockquote></div> 

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: rows estimate in explain analyze for the BRIN index
Next
From: Tom Lane
Date:
Subject: Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)