Re: [PATCH] minor reloption regression tests improvement - Mailing list pgsql-hackers

From Greg Stark
Subject Re: [PATCH] minor reloption regression tests improvement
Date
Msg-id CAM-w4HODaFSVjz0R4XMYeN+bbEhcq0=H-hwq3TLSL-OriiUHpA@mail.gmail.com
Whole thread Raw
In response to [PATCH] minor reloption regression tests improvement  (Nikolay Shaplov <dhyan@nataraj.su>)
Responses Re: [PATCH] minor reloption regression tests improvement
Re: [PATCH] minor reloption regression tests improvement
List pgsql-hackers
I don't think this is worth spending time adding tests for. I get what
you're saying that this is at least semi-intentional behaviour and
desirable behaviour so it should have tests ensuring that it continues
to work. But it's not documented behaviour and the test is basically
testing that the implementation is this specific implementation.

I don't think the test is really a bad idea but neither is it really
very useful and I think it's not worth having people spend time
reviewing and discussing. I'm leaning to saying this patch is
rejected.



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: role self-revocation
Next
From: Zhihong Yu
Date:
Subject: refreshing query id for pg_stat_statements based on comment in sql