Re: Review: UNNEST (and other functions) WITH ORDINALITY - Mailing list pgsql-hackers

From Greg Stark
Subject Re: Review: UNNEST (and other functions) WITH ORDINALITY
Date
Msg-id CAM-w4HNTA=SuprQ70y+=BWuh1=-voX6nTm0fr5p1_6jRzxkDkg@mail.gmail.com
Whole thread Raw
In response to Re: Review: UNNEST (and other functions) WITH ORDINALITY  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Review: UNNEST (and other functions) WITH ORDINALITY
Re: Review: UNNEST (and other functions) WITH ORDINALITY
List pgsql-hackers
On Wed, Jul 24, 2013 at 6:39 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> This patch will introduce, without documentation, a fifth class of
> keyword.  ORDINALITY will need to be quoted when, and only when, it
> immediately follows WITH.  Without some change to our deparsing code,
> this is a dump/restore hazard; and with some such change it's still
> probably not a good idea.

Strictly speaking this patc doesn't introduce this fifth class of
keyword. We already had TIME in that category (and also FIRST and LAST
in a similar category following NULLS). If we have a solution for WITH
<keyword> then presumably we would implement it for WITH TIME and WITH
ORDINALITY at the same time.

In the interim I suppose we could teach pg_dump to quote any keyword
that follows WITH or NULLS pretty easily. Or just quote those four
words unconditionally.

-- 
greg



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Adding Zigzag Merge Join to Index Nested Loops Join
Next
From: Andres Freund
Date:
Subject: Re: ilist.h is not useful as-is