Re: Fix uninitialized xl_running_xacts padding - Mailing list pgsql-hackers

From Alexander Kuzmenkov
Subject Re: Fix uninitialized xl_running_xacts padding
Date
Msg-id CALzhyqzKTRVsQGj+qDDRVs3Oo0EvffuQvVO0v4rbpWU=SoXKug@mail.gmail.com
Whole thread
In response to Re: Fix uninitialized xl_running_xacts padding  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Fix uninitialized xl_running_xacts padding
List pgsql-hackers
On Tue, Mar 10, 2026 at 11:09 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> +1 for initializing all padding in WAL records. In fact I thought that
> we already did that. (Except in this case, apparently)

I found 42 exceptions like this. See the attached patch, it
initializes some WAL records and removes the WAL-related Valgrind
suppressions. The regression tests pass under Valgrind with these
changes.

As discussed above, I used memset instead of = { 0 }. I could observe
the latter to not initialize the padding on some configurations.

Attachment

pgsql-hackers by date:

Previous
From: Viktor Holmberg
Date:
Subject: Re: support fast default for domain with constraints
Next
From: Peter Eisentraut
Date:
Subject: Re: Define DatumGetInt8 function.