Re: Add new error_action COPY ON_ERROR "log" - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Add new error_action COPY ON_ERROR "log"
Date
Msg-id CALj2ACXrsZR6YvdtfbPdpb7S_5nX+Avi0P-3ApupTBnfh12HJQ@mail.gmail.com
Whole thread Raw
In response to Re: Add new error_action COPY ON_ERROR "log"  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Add new error_action COPY ON_ERROR "log"
List pgsql-hackers
On Thu, Mar 28, 2024 at 6:31 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> That is,
> since the LOG_VERBOSITY option is an enum parameter, it might make
> more sense to require the value, instead of making the value optional.
> For example, the following command could not be obvious for users:
>
> COPY test FROM stdin (ON_ERROR ignore, LOG_VERBOSITY);

Agreed. Please see the attached v14 patch. The LOG_VERBOSITY now needs
a value to be specified. Note that I've not added any test for this
case as there seemed to be no such tests so far generating "ERROR:
<<option>> requires a parameter". I don't mind adding one for
LOG_VERBOSITY though.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgbnech: allow to cancel queries during benchmark
Next
From: walther@technowledgy.de
Date:
Subject: Re: Building with musl in CI and the build farm