Re: correct the sizes of values and nulls arrays in pg_control_checkpoint - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
Date
Msg-id CALj2ACXrDr5EN0uABDPSb0af8JOn1WQG8CBXX0GFRc4eBEuXEQ@mail.gmail.com
Whole thread Raw
In response to Re: correct the sizes of values and nulls arrays in pg_control_checkpoint  ("Euler Taveira" <euler@eulerto.com>)
Responses Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
List pgsql-hackers
On Thu, Dec 23, 2021 at 9:13 PM Euler Taveira <euler@eulerto.com> wrote:
>
> On Thu, Dec 23, 2021, at 8:39 AM, Bharath Rupireddy wrote:
>
> pg_control_checkpoint emits 18 columns whereas the values and nulls
> arrays are defined to be of size 19. Although it's not critical,
> attaching a tiny patch to fix this.
>
> Good catch! I'm wondering if a constant wouldn't be useful for such case.

Thanks. I thought of having a macro, but it creates a lot of diff with
the previous versions as we have to change for other pg_control_XXX
functions.

Regards,
Bharath Rupireddy.



pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
Next
From: "Euler Taveira"
Date:
Subject: Re: Delay the variable initialization in get_rel_sync_entry