Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData? - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?
Date
Msg-id CALj2ACX17G7F-jeLt+7KhJ6YxVeRwR8Zk0rDh4VnT546o0UpTQ@mail.gmail.com
Whole thread Raw
Responses Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi,

The active_pid of ReplicationSlot structure, which tells whether a
replication slot is active or inactive, isn't persisted to the disk
i.e has no entry in ReplicationSlotPersistentData structure. Isn't it
better if we add that info to ReplicationSlotPersistentData structure
and persist to the disk? This will help to know what were the inactive
replication slots in case the server goes down or crashes for some
reason. Currently, we don't have a way to interpret the replication
slot info in the disk but there's a patch for pg_replslotdata tool at
[1]. This way, one can figure out the reasons for the server
down/crash and figure out which replication slots to remove to bring
the server up and running without touching the other replication
slots.

Thoughts?

[1] - https://www.postgresql.org/message-id/CALj2ACW0rV5gWK8A3m6_X62qH%2BVfaq5hznC%3Di0R5Wojt5%2Byhyw%40mail.gmail.com

Regards,
Bharath Rupireddy.



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: should we document an example to set multiple libraries in shared_preload_libraries?
Next
From: Daniel Gustafsson
Date:
Subject: Re: stat() vs ERROR_DELETE_PENDING, round N + 1