Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Date
Msg-id CALj2ACWdaBG9Yn0yNdukqOOeebbxQ+MTgoMh_QaR8eUCup7s2g@mail.gmail.com
Whole thread Raw
In response to Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
List pgsql-hackers
On Thu, Jun 10, 2021 at 9:17 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
> > I don't know the answer; my guess is that all this has become obsolete
> > and the whole Assert and the dodgy comment can just be deleted.
>
> Hm. I get it. Unfortunately the commit b1ff33f is missing information
> on what the coverity tool was complaining of and it has no related
> discussion at all.
>
> I agree to remove that assertion entirely. I will post a new patch set soon.

PSA v5 patch set.

With Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: speed up verifying UTF-8
Next
From: Andrew Dunstan
Date:
Subject: Re: BF assertion failure on mandrill in walsender, v13