Postgres Pro
Downloads
Home   >   mailing lists

Re: CREATE COLLATION - check for duplicate options and error out if found one - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: CREATE COLLATION - check for duplicate options and error out if found one
Date
Msg-id CALj2ACWDSZvoRm89CVL2mmuod9_gmtUs_PLDt2mYfKbvnpNTeA@mail.gmail.com
Whole thread Raw
In response to Re: CREATE COLLATION - check for duplicate options and error out if found one  (vignesh C <vignesh21@gmail.com>)
Responses Re: CREATE COLLATION - check for duplicate options and error out if found one  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Tree view 
On Sat, May 29, 2021 at 9:08 PM vignesh C <vignesh21@gmail.com> wrote:
> One minor comment:
> You can remove the brackets around errcode, You could change:
> + if (localeEl)
> + ereport(ERROR,
> + (errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("option \"%s\" specified more than once", defel->defname),
> + parser_errposition(pstate, defel->location)));
> to:
> + if (localeEl)
> + ereport(ERROR,
> + errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("option \"%s\" specified more than once", defel->defname),
> + parser_errposition(pstate, defel->location));

Thanks. PSA v3 patch.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Addition of alias types regpublication and regsubscription
Next
From: Tom Lane
Date:
Subject: Re: CALL versus procedures with output-only arguments