Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable() - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable()
Date
Msg-id CALj2ACVdONLuOzOTQ8at+LJT22Renjbb_ZYjwfouHE9byarqwg@mail.gmail.com
Whole thread Raw
In response to Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable()  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable()  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Sat, Mar 4, 2023 at 8:14 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Sat, Mar 4, 2023 at 8:00 AM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Fri, Mar 03, 2023 at 04:33:39PM -0800, Nathan Bossart wrote:
> > > Given both Bharath and I missed this, perhaps we should add a comment about
> > > this behavior.
> >
> > Makes sense to me to document that in a better way.  What about the
> > addition of a short paragraph at the top of XLogFileReadAnyTLI() that
> > explains the behaviors we expect depending on the values of
> > XLogSource?  The case of XLOG_FROM_ANY with the order to scan the
> > archives then pg_wal/ for each timeline is the most important bit,
> > surely.
>
> +1. I will send a patch in a bit.

Okay, here's a patch attached.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable()
Next
From: Jeff Davis
Date:
Subject: Re: Move defaults toward ICU in 16?