Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix a comment in basic_archive about NO_INSTALLCHECK - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Fix a comment in basic_archive about NO_INSTALLCHECK
Date
Msg-id CALj2ACVR2tes=E=kWGvZerPm6Y4BHw9nQWCfLFx1cxPkPK-zhg@mail.gmail.com
Whole thread Raw
In response to Re: Fix a comment in basic_archive about NO_INSTALLCHECK  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Fix a comment in basic_archive about NO_INSTALLCHECK
List pgsql-hackers
Tree view 
On Thu, Apr 6, 2023 at 9:26 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Apr 03, 2023 at 08:56:10AM +0530, Bharath Rupireddy wrote:
> > It looks like comments in make file and meson file about not running
> > basic_archive tests in NO_INSTALLCHECK mode are wrong. The comments say the
> > module needs to be loaded via shared_preload_libraries=basic_archive, but
> > it actually doesn't. The custom file needs archive related parameters and
> > wal_level=replica. Here's a patch correcting that comment.
>
> Saying that, updating the comments about the dependency with
> archive_library and the module's GUC is right.

Reworded the comment a bit and attached the v2 patch.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: "Andrey M. Borodin"
Date:
Subject: Re: Transaction timeout
Next
From: John Naylor
Date:
Subject: Re: Change GUC hashtable to use simplehash?