correct the sizes of values and nulls arrays in pg_control_checkpoint - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject correct the sizes of values and nulls arrays in pg_control_checkpoint
Date
Msg-id CALj2ACVQ=hAs=sT0n4xriimqRrrgECySfg_tSqA+26Rb_yfs2A@mail.gmail.com
Whole thread Raw
Responses Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
List pgsql-hackers
Hi,

pg_control_checkpoint emits 18 columns whereas the values and nulls
arrays are defined to be of size 19. Although it's not critical,
attaching a tiny patch to fix this.

diff --git a/src/backend/utils/misc/pg_controldata.c
b/src/backend/utils/misc/pg_controldata.c
index 209a20a882..b1db9a8d07 100644
--- a/src/backend/utils/misc/pg_controldata.c
+++ b/src/backend/utils/misc/pg_controldata.c
@@ -79,8 +79,8 @@ pg_control_system(PG_FUNCTION_ARGS)
 Datum
 pg_control_checkpoint(PG_FUNCTION_ARGS)
 {
-       Datum           values[19];
-       bool            nulls[19];
+       Datum           values[18];
+       bool            nulls[18];
        TupleDesc       tupdesc;
        HeapTuple       htup;
        ControlFileData *ControlFile;

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: skip replication slot snapshot/map file removal during end-of-recovery checkpoint
Next
From: Fabien COELHO
Date:
Subject: Re: psql - add SHOW_ALL_RESULTS option