Re: pgsql: Fix calculation of relid sets for partitionwise child joins. - Mailing list pgsql-committers

From Bharath Rupireddy
Subject Re: pgsql: Fix calculation of relid sets for partitionwise child joins.
Date
Msg-id CALj2ACVH=Eqri6tJ2oOBkiBpAF4wVcbPNsOhWoZCG0=RyD-1Qw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix calculation of relid sets for partitionwise child joins.  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: pgsql: Fix calculation of relid sets for partitionwise child joins.
List pgsql-committers
On Sat, Jul 22, 2023 at 4:22 AM Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Fri, 2023-07-21 at 16:00 +0000, Tom Lane wrote:
> > Fix calculation of relid sets for partitionwise child joins.
>
> In CI, I'm seeing a compiler warning here:
>
> https://cirrus-ci.com/task/6112262960709632
>
> [22:28:11.772] joinrels.c: In function ‘try_partitionwise_join’:
> [22:28:11.772] joinrels.c:1546:11: error: variable ‘child_joinrelids’
> set but not used [-Werror=unused-but-set-variable]
> [22:28:11.772]  1546 |   Relids  child_joinrelids;
> [22:28:11.772]       |           ^~~~~~~~~~~~~~~~
> [22:28:11.772] cc1: all warnings being treated as errors

Same here - https://github.com/BRupireddy/postgres/runs/15251297440.
Might have to mark the child_joinrelids PG_USED_FOR_ASSERTS_ONLY.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: pgsql: Fix calculation of relid sets for partitionwise child joins.
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid compiler warning in non-assert builds.