Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views
Date
Msg-id CALj2ACVAcXZ+OLmqqaa44hD8vsQCQFnjb8UatC+xhq4kkGfvJg@mail.gmail.com
Whole thread
Responses Re: DROP INVALID INDEXES command
List pgsql-hackers
Hi,

On Mon, Aug 31, 2026 at 1:50 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> > I think this should reuse errdetail_relkind_not_supported().
>
> Yes, that's better, let's reuse.
>
> > I would
> > add a trivial test as Kiran Kaki suggested though.
>
> That's fine with me, I can add one for materialized views here in this
> patch.

Please find the attached v2.

> Going by this, I think we also need tests for catalogs, TOAST,
> and other repack-restricted cases. I'd let Kiran Kaki add such tests
> in a new thread.

I realized that except for the wal_level and replica identity related
errors, repack seems to already have tests for the other restricted
cases.

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Add TG_* vars for FOR PORTION OF
Next
From: Mihail Nikalayeu
Date:
Subject: Re: Routed ON CONFLICT inserts broken by partition-local deferrable unique constraints in 19 and master